Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix report plots #335

Merged
merged 13 commits into from
May 28, 2024
Merged

Fix report plots #335

merged 13 commits into from
May 28, 2024

Conversation

ggabernet
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/airrflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

ssnn-airr
ssnn-airr approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@ssnn-airr ssnn-airr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nf-core nf-core deleted a comment from github-actions bot May 28, 2024
@ggabernet ggabernet merged commit 7b0cdc3 into nf-core:dev May 28, 2024
21 of 28 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 094f254

+| ✅ 270 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-28 22:21:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssnn-airr ssnn-airr ssnn-airr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggabernet @ssnn-airr @nf-core-bot